Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] feat: renamed custom media query #2495

Merged
merged 1 commit into from
Aug 3, 2023
Merged

[BD-46] feat: renamed custom media query #2495

merged 1 commit into from
Aug 3, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Aug 3, 2023 •
edited
Loading

Description

Issue: #2444

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Aug 3, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 51e699a
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64cb643205f2640008c89cc9
😎 Deploy Preview https://deploy-preview-2495--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Aug 3, 2023
Closed
@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Aug 3, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

adamstankiewicz
adamstankiewicz approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tokens/style-dictionary.js
@@ -185,9 +186,9 @@ StyleDictionary.registerFormat({

for (let i = 0; i < breakpoints.length; i++) {
const [currentBreakpoint, nextBreakpoint] = [breakpoints[i], breakpoints[i + 1]];
customMediaVariables += `@custom-media --min-${currentBreakpoint.name} (min-width: ${currentBreakpoint.value});\n`;
customMediaVariables += `${composeBreakpointName(currentBreakpoint.name, 'min')} (min-width: ${currentBreakpoint.value});\n`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor to abstract this out into a helper function!

@adamstankiewicz adamstankiewicz linked an issue Aug 3, 2023 that may be closed by this pull request
[alpha] Rename custom media query output to ensure pgn namespace is the prefix #2444
Closed
@adamstankiewicz adamstankiewicz merged commit 8959d73 into openedx:alpha Aug 3, 2023
7 checks passed
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.41 🎉

The release is available on:

Your semantic-release bot 📦🚀

monteri pushed a commit to raccoongang/paragon that referenced this pull request Aug 17, 2023
@PKulkoRaccoonGang
fix: renamed custom media query (openedx#2495)
00ba260
PKulkoRaccoonGang added a commit to raccoongang/paragon that referenced this pull request Aug 18, 2023
@PKulkoRaccoonGang
fix: renamed custom media query (openedx#2495)
833eb47
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 23.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

PKulkoRaccoonGang added a commit that referenced this pull request Aug 1, 2024
@PKulkoRaccoonGang
fix: renamed custom media query (#2495)
d63c2ec
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
@PKulkoRaccoonGang
fix: renamed custom media query (#2495)
38582a1
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
@PKulkoRaccoonGang
fix: renamed custom media query (#2495)
de07eca
PKulkoRaccoonGang added a commit that referenced this pull request Aug 5, 2024
@PKulkoRaccoonGang
fix: renamed custom media query (#2495)
6bd6bfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monteri monteri monteri approved these changes

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha
Projects
No open projects
2U Blended Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[alpha] Rename custom media query output to ensure pgn namespace is the prefix
6 participants
@PKulkoRaccoonGang @openedx-webhooks @edx-semantic-release @openedx-semantic-release-bot @adamstankiewicz @monteri